search

orbitalquark / textadept

Textadept is a fast, minimalist, and remarkably extensible cross-platform text editor for programmers.
https://orbitalquark.github.io/textadept
MIT License
636 stars 38 forks source link

List Dialog Default Button + button3 Qt support #423

Closed jxzwp closed 1 year ago

jxzwp commented 1 year ago

Using yesterday's nightly version of Textadept Qt...

When a ui.dialogs.list() is displayed and the user presses Enter, it should be the equivalent of pressing button1 (the OK button by default). However this is not the case, button2 is effectively pressed instead. This is despite button1 being the one that focused, based on how it's drawn.

I suspect a default button needs to be set as you did here https://github.com/orbitalquark/textadept/blob/0bac5dbe488dea8a722ae88bbad5281ab95c6221/src/textadept_qt.cpp#L369-L370C

Also the docs say button3 is not supported under Qt for ui.dialogs.input(). I think the same note should be in the docs for ui.dialogs.list() and ui.dialogs.message(), because button3 doesn't seem to work for them either.

Thanks.

jxzwp commented 1 year ago

Sorry, my mistake, I think something in my profile was causing the behavior. I've re-tested it under Textadept 12 beta with a clean USERHOME and ui.dialogs.list(), ui.dialogs.message() and ui.dialogs.input() all work as intended and documented.

When you specify a button3 it appears as the middle button, I assume that is intended behavior.