Closed fiddleyuan closed 8 months ago
The issue fixed by explicitly put #include <QDesktopWidget>
in build/_deps/scintilla-src/qt/ScintillaEditBase/PlatQt.cpp
Then I came across second compile issue where filter.setFilterRegularExpression was incomplete in src/textadept_qt.cpp and I found this was caused by https://github.com/orbitalquark/textadept/commit/8b19c29606c540c23942fdcb8bb405bf0ef50768 Now the workaround is to revert this change.
So both compilation issue was caused by QT version. Maybe my Ubuntu 18.04 is way obsolete.
Yes, unfortunately the version of Qt provided by Ubuntu 18.04 is not high enough. The undocumented floor for Textadept is Qt 5.12 (Ubuntu 20.04). Once 20.04 becomes unsupported, the floor will probably go up to Qt 5.15 (Ubuntu 22.04) in order to simplify some code -- the code you linked to has comments that Qt 5.15 provides some things that Qt 5.12 does not have.
Also, the author of Scintilla works really hard to make sure Scintilla compiles and runs on a wide array of supported platforms. Since Ubuntu 18.04 is not supported anymore, I doubt compatibility with legacy platforms is a priority.
It's good that you found a workaround, but while Textadept may work with older versions of Qt, it may not do so indefinitely.
Yes, unfortunately the version of Qt provided by Ubuntu 18.04 is not high enough. The undocumented floor for Textadept is Qt 5.12 (Ubuntu 20.04). Once 20.04 becomes unsupported, the floor will probably go up to Qt 5.15 (Ubuntu 22.04) in order to simplify some code -- the code you linked to has comments that Qt 5.15 provides some things that Qt 5.12 does not have.
Also, the author of Scintilla works really hard to make sure Scintilla compiles and runs on a wide array of supported platforms. Since Ubuntu 18.04 is not supported anymore, I doubt compatibility with legacy platforms is a priority.
It's good that you found a workaround, but while Textadept may work with older versions of Qt, it may not do so indefinitely.
Thanks @orbitalquark for the clarification. I'll close the issue now.
I'm trying to compile textadept on Ubuntu 18.04 with Qt version 5.9.5, got some warnings during cmake configuration stage, and failed when trying to build dependent scintilla. Could someone help me figure out what might go wrong? I'm completely new to either textadept or QT and scintilla, thanks
cmake -S . -B build -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
cmake --build build