orbitdb-archive / ipfs-log

Append-only log CRDT on IPFS
https://orbitdb.github.io/ipfs-log/
MIT License
398 stars 55 forks source link

chore(dependencies): Applying Alan Shaw's js-ipfs 0.33.0 upgrades #185

Closed aphelionz closed 6 years ago

aphelionz commented 6 years ago

Maintenance PR for applying @alanshaw's changes as described here https://github.com/orbitdb/ipfs-log/issues/183

Updates:

Next Steps (after this PR)

Resolves #183

aphelionz commented 6 years ago

@RichardLitt Check one more time.

haadcode commented 6 years ago

@aphelionz thank you, looking good 👍

However, we shouldn't update the package version here as we would do that only upon on a npm new release, from master. That is, the package version gets updated manually as part of the npm release process and shouldn't be changed in PRs.

aphelionz commented 6 years ago

@haadcode roger that. I'll change it back

aphelionz commented 6 years ago

@haadcode all set!

haadcode commented 6 years ago

LGTM 👍

RichardLitt commented 6 years ago

@haadcode Would Greenkeeper help here?

haadcode commented 6 years ago

@RichardLitt we had Greenkeeper for all the ecosystem modules in the past. We turned it off because, well, it wasn't so helpful (more noise than signal). This was couple of years ago, they have prolly improved on it and generally if people feel like it can be helpful, we can definitely start using it again 👍

RichardLitt commented 6 years ago

Ah, yeah, I remember that. I think it's a bit better now - but keeping the noise down is hard. Might make sense to jerry-rig something similar that only updates once every three months. Would that be useful?