Log.values as log traversal

orbitdb-archive / ipfs-log

Append-only log CRDT on IPFS

https://orbitdb.github.io/ipfs-log/

MIT License

398 stars 55 forks source link

Log.values as log traversal #193

Closed aphelionz closed 5 years ago

aphelionz commented 5 years ago

Description (Required)

This change modifies the Log.values function to traverse the log, using the DAG as the source of truth rather than a sort.

Other changes (e.g. bug fixes, UI tweaks, refactors)

The behavior of this changes how heads are sorted. This requires changing some tests around.

[ ] test/log-heads-tails.spec.js
[ ] test/log.spec.js

Additionally there seemed to be a test that should not have passed before, but did, and is fixed now.

[ ] test/log.spec.js

TODO

TBD

haadcode commented 5 years ago

This is now ready from my side, nothing to add. As soon as the Ci is green, I'd be ready to merge this. @aphelionz do you want to review it once more before we do that?