Traversal Improvements - Githubissues

orbitdb-archive / ipfs-log

Append-only log CRDT on IPFS

https://orbitdb.github.io/ipfs-log/

MIT License

398 stars 55 forks source link

Traversal Improvements #201

Closed aphelionz closed 5 years ago

aphelionz commented 5 years ago

From: https://github.com/ipfs/dynamic-data-and-capabilities/issues/50

Provide a way to efficiently and incrementally traverse the log. If I request the last 5 entries, there should be as less traversal and I/O as possible to accomplish that. Also, it should be able to have some kind of resume of the traversal, for pagination use-cases.
Ensure that the traversal of the tree happens concurrently, as much as possible. We can obviously improve later on.

aphelionz commented 5 years ago

@satazor We just merged in a version of the log.values function that traverses the log. Have a look and let me know where we should go from there.

aphelionz commented 5 years ago

@satazor Friendly reminder to review the code currently in two places and let me know if this is sufficient:

satazor commented 5 years ago

Yes I will review those as soon as I get back from holidays, which is Jan 4th. If I have the time, I will do it sooner.

aphelionz commented 5 years ago

Ok cool, enjoy the holidays :)

aphelionz commented 5 years ago

@satazor one more nudge to check out the recent traversal improvements to see if they work for you

satazor commented 5 years ago

@aphelionz I think the lines you linked are pointing to the wrong lines because commits were made in master meanwhile.

aphelionz commented 5 years ago

oops! updated.

satazor commented 5 years ago

I think traverse is what I need and it seems that it respects the amount efficiently. Perhaps, we are missing making it officially part of the public API.

aphelionz commented 5 years ago

Yes, I'm working on documentation that will clarify that. I'll close this ticket for now.