orbitdb-archive / ipfs-log

Append-only log CRDT on IPFS
https://orbitdb.github.io/ipfs-log/
MIT License
398 stars 55 forks source link

fix: typo with lt param of iterator #304

Closed mistakia closed 3 years ago

mistakia commented 4 years ago

Fix small typo with lt param of the iterator method.

[ ] Add test to catch this in the future

aphelionz commented 4 years ago

How are you feeling about this one @mistakia ? :)

mistakia commented 4 years ago

Taking a look at it again it seems like it's only a problem when next is an array of more than a single item.

What's the best way to create such a situation for the tests? would increasing the pointer count from 1 to 2 suffice?

aphelionz commented 3 years ago

The test would be nice but I think the biggest thing here is just to run npm run build and commit the dist file changes :+1:

Otherwise LGTM