ipfs-log@4.6.4 is breaking old orbit-db releases

orbitdb-archive / ipfs-log

Append-only log CRDT on IPFS

https://orbitdb.github.io/ipfs-log/

MIT License

398 stars 55 forks source link

ipfs-log@4.6.4 is breaking old orbit-db releases #310

Closed oed closed 4 years ago

oed commented 4 years ago

We've noticed that cids@1.0.0 is being pulled in from orbit-db-io into this package. This is a breaking change and the v1.0 of cids is not compatible with older versions. Since only the patch version of this package was updated it's causing issues upstream.

I would recommend that:

ipfs-log@4.6.5 is released which rolls back the update to cids
`ipfs-log@5.0.0´ is released which would contain the new cids version

aphelionz commented 4 years ago

Good call @oed, will do ASAP

oed commented 4 years ago

Thank you @aphelionz 🙏 Some of our users have been seeing issues because of this :)

aphelionz commented 4 years ago

[x] hotfix/v4.6.5 branch pushed and v4.6.5 published to npm
[x] v5.0.0 will be pushed to master and published to the @next tag. Tests that were passing two days ago are now failing :P

aphelionz commented 4 years ago

idk, looks like the go-ipfs tests are messed up now. @oed at least let me know if 4.6.5 fixes the issue for you

oed commented 4 years ago

Looks good based on the dependency tree.