search

orbitdb-archive / ipfs-log

Append-only log CRDT on IPFS
https://orbitdb.github.io/ipfs-log/
MIT License
398 stars 55 forks source link

tests use undefined config property to name folder #321

Closed tabcat closed 3 years ago

tabcat commented 3 years ago

Currently many tests use a property that is undefined as part of the path for the ipfs repo option. This results in folders created being named undefined-entry-io1608448165710 instead of <repo name>-entry-io1608448165710. These folders are created in the project root and are not ignored by git.

example of issue https://github.com/orbitdb/ipfs-log/blob/b8e4b76247d1bd9b5fa8ad751a62d7f0f3f3f560/test/entry-io.spec.js#L29 (repo option)

https://github.com/orbitdb/orbit-db-test-utils/blob/fb3cddc0774397de83df47a26c0109f77ed92884/config/node.js#L7-L32 (no repo property on config.defaultIpfsConfig)

test files with issue

test/entry-io.spec.js
test/entry.spec.js
test/log-append.spec.js
test/log-crdt.spec.js
test/log-head-tails.spec.js
test/log-iterator.spec.js
test/log-join-concurrent.spec.js
test/log-join.spec.js
test/log-load.spec.js
test/log-references.spec.js
test/log.spec.js
test/signed-log.spec.js