orbitdb-archive / orbit-db-identity-provider

Default identity provider for OrbitDB
MIT License
31 stars 17 forks source link

Updating orbit-db-keystore #72

Closed aphelionz closed 3 years ago

tabcat commented 3 years ago

I've found the problems here.

1) I made a change in https://github.com/orbitdb/orbit-db-keystore/pull/60 that i shouldn't have as it wasn't necessary; i had left a comment regarding it before it had been merged. 2) key.public.marshal() calls in tests need to be wrapped with a Buffer.from call because, with the new libp2p-crypto version, Uint8Arrays are used in place of Buffers. TypedArrays dont have the built in same .toString method as Buffers and don't support encoding to a hex string.

I'll make a pr to the keystore and add the Buffer changes to the tests here.