search

orbitdb-archive / orbit-db-pubsub

Message propagation module for orbit-db
MIT License
19 stars 14 forks source link

Update needed for haadcode/ipfs-pubsub-room#orbitdb package #7

Closed mistakia closed 6 years ago

mistakia commented 6 years ago

Hey - ipfs-pubsub-room needs to be updated to use the correct method when dialing with protocol

ipfs-shipyard/ipfs-pubsub-room@852d0fa

ztl8702 commented 6 years ago

+1 for this. I just got hit by a ipfs-pubsub-room bug that was fixed in the latest version. See my comment here.

I was running an orbit-db instance in custom Node.js code and having a separate oribit-db-cli running. Whenever CLI tries to replicate the Node.js instance, the latter would crash.

ztl8702 commented 6 years ago

As a workaround, I added these lines to my package.json and it seems to resolve the problem for now:

"resolutions": {
    "orbit-db/orbit-db-pubsub/ipfs-pubsub-room": "1.2.0"
}

Reference: https://yarnpkg.com/lang/en/docs/selective-version-resolutions/

I am using yarn 1.5.1.

However I did notice that @haadcode maintains a separate version of ipfs-pubsub-room, and there were a few patches applied to the orbitdb branch:

Not sure what effects they have tho. Would love to help if possible.

haadcode commented 6 years ago

Thanks for reporting the issue @krahimian and for providing details @ztl8702! This was indeed a problem that popped up with the latest updates to IPFS due us using a fork.

This has now been fixed in https://github.com/orbitdb/orbit-db-pubsub/pull/8 and I just published v0.4.0 on npm that contains the fix.

Let us know if there are any more problems!