search

orbitdb-archive / orbit-db-store

Base class for orbit-db data stores
MIT License
40 stars 22 forks source link

Close access controller on Store.close() #115

Closed julienmalard closed 3 years ago

julienmalard commented 3 years ago

Resolves point 2 of https://github.com/orbitdb/orbit-db/issues/906. Not too sure where and how to add a test to avoid future regressions though. Thanks!

tabcat commented 3 years ago

unfortunately the default access controller for the Store class doesn't follow the access controller interface.

tabcat commented 3 years ago

fixed in https://github.com/orbitdb/orbit-db-store/commit/1b666605b935bda3f53991632fe389d11544dfdb

tabcat commented 3 years ago

there should be a better long term fix, that default access controller on the store is a bit odd now.