search

orbitdb-archive / orbit-db-store

Base class for orbit-db data stores
MIT License
40 stars 22 forks source link

Fix replication progress callbacks #119

Closed haadcode closed 2 years ago

haadcode commented 2 years ago

This PR fixes a bug where replicate.progress wasn't emitted correctly when a log has concurrent ops.

haadcode commented 2 years ago

This PR is to fix the issue @vinkabuki reported in #orbitdb chat

holmesworcester commented 2 years ago

Thank you! ❤️

This fix is huge for us!

vinkabuki commented 2 years ago

Maybe it's worth to include the test I wrote in this MR too?

tabcat commented 2 years ago

@vinkabuki the test belongs in the orbitdb repo, feel free to open a pr for that.

tabcat commented 2 years ago

@vinkabuki i just looked and there is a test file for the replicator in this repo so if you want to make one here thats fine too; in a separate pr.

tabcat commented 2 years ago

published with version 4.3.3