orbitdb-archive / orbit

A distributed, serverless, peer-to-peer chat application on IPFS
MIT License
1.64k stars 116 forks source link

Orbit browser version problems #210

Closed haadcode closed 7 years ago

haadcode commented 7 years ago

Report bugs with the browser version here.

dignifiedquire commented 7 years ago

version: https://ipfs.io/ipfs/QmZkHVcXTffZQ9FxCR175wcGXtuaaejfHovQCLegYeD3qx/

Drag and drop fails:

screen shot 2016-12-13 at 19 26 02

No messages are being loaded:

screen shot 2016-12-13 at 19 28 03
haadcode commented 7 years ago
screen shot 2016-12-13 at 19 30 51 screen shot 2016-12-13 at 19 30 56
haadcode commented 7 years ago

One more new one:

screen shot 2016-12-14 at 01 32 12
dignifiedquire commented 7 years ago

Reload is loosing the history. Even though I had a pretty long history, after a simple reload the history is empty (same channel, same username). The loading indicator is running though.

dignifiedquire commented 7 years ago

screen shot 2016-12-14 at 18 45 56

haadcode commented 7 years ago

I'm also losing history on Firefox but not in chrome. @dignifiedquire can you try with both?

dignifiedquire commented 7 years ago

will try firefox later, but definitely seeing it in chrome

dignifiedquire commented 7 years ago

Floodsub error: https://github.com/libp2p/js-libp2p-floodsub/issues/11

screen shot 2016-12-14 at 16 22 07
dignifiedquire commented 7 years ago

There is a new build, with master + this bitswap branch: https://github.com/ipfs/js-ipfs-bitswap/tree/new which makes things really nice https://ipfs.io/ipfs/QmXi4w3S3DqcbESA28yYw63MWNhfs3oUK8b8FSfxjb6N1S

Things are faster and stabler even with > 5 peers now.

haadcode commented 7 years ago

Chrome doesn't play videos but throws an error related to "SourceBuffer". No idea why as this used to work and the code hasn't been touched. Could be a Chrome bug https://bugs.chromium.org/p/chromium/issues/detail?id=651904.

Firefox plays frags_bunny.mp4 still fine :)

dignifiedquire commented 7 years ago

This is the relevant PR https://github.com/ipfs/js-ipfs-bitswap/pull/83

victorb commented 7 years ago

Not sure if it's specific to the browser version of orbit but seemingly .webm videos don't play in Orbit.

On Thu, Dec 15, 2016 at 7:46 PM, Friedel Ziegelmayer < notifications@github.com> wrote:

This is the relevant PR ipfs/js-ipfs-bitswap#83 https://github.com/ipfs/js-ipfs-bitswap/pull/83

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haadcode/orbit/issues/210#issuecomment-267407734, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcD9NjzV5bHJooUI_N0BweHnYF0k178ks5rIYr5gaJpZM4LMEay .

dignifiedquire commented 7 years ago

I tracked the history loading bug a bit more, and it seems that the ipfs-log is corrupted somehow. For example one state in https://github.com/haadcode/orbit-db-store/blob/master/src/Store.js#L56 for merged is

[
  {
    "hash": "QmQW8x8N39iRZ8KA6UesUkvhYXJTBEAZX7uirXU9mU1jW9",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "QmTFRa2XRbRrRS8vegx6XEbSDXziVN7NZXhf4w56g1Z2y7",
      "meta": {
        "ts": 1481903123114
      }
    },
    "next": []
  },
  {
    "hash": "Qmf7ByHNzK9ucPfRmfBmWgt57qsJJneV9bvQXTo9TZ54pD",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "QmQnwJVNXXqpfQ8YFKkrJdBWC8J7eV4x8uS8cy5W9CDvz1",
      "meta": {
        "ts": 1481903482746
      }
    },
    "next": [
      "QmQW8x8N39iRZ8KA6UesUkvhYXJTBEAZX7uirXU9mU1jW9"
    ]
  },
  {
    "hash": "QmPZRCHb5YZPH4tt9XGEJiBfhqMSzCtaCT6QtR2MvWg6hJ",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "QmY5RsuxCivuwkhXZ7BWwjaTNH7ZjcaoGAuhXJQqWdYYAk",
      "meta": {
        "ts": 1481903489122
      }
    },
    "next": [
      "Qmf7ByHNzK9ucPfRmfBmWgt57qsJJneV9bvQXTo9TZ54pD"
    ]
  },
  {
    "hash": "QmQ2D7ukrwAkGZFYSswV2vhZD2NNZggyYg9XjDwmfoDxf5",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "Qmd8ANPigXwLUdVF7NDdvyZaLRHSquTBZwdmmADdwjvhVN",
      "meta": {
        "ts": 1481903490713
      }
    },
    "next": [
      "QmPZRCHb5YZPH4tt9XGEJiBfhqMSzCtaCT6QtR2MvWg6hJ"
    ]
  },
  {
    "hash": "QmfXHmjWrtNvcWBNPM17ixadXSiKrYqiVSddgfctK5jktH",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "QmYNKikyQEK3GHTbEMqngnABbQMKv9LPP7TJGmnrppGTm8",
      "meta": {
        "ts": 1481903544102
      }
    },
    "next": [
      "QmQ2D7ukrwAkGZFYSswV2vhZD2NNZggyYg9XjDwmfoDxf5"
    ]
  }
]

Where the important part is the empty next of the first item. But before the reload the (visual) history was much longer and there where items before the first item.

haadcode commented 7 years ago

Most of these issues should now be fixed in master. Specifically the problems related to the messages loading are now fixed.

I'm going to close this one in order to have more granular issues for each specific bug in the future. Please open new issues as you come across bugs.

Thank you everyone for reporting the issues and participating in testing!