search

orbitersim / orbiter

Open-source repository of Orbiter Space Flight Simulator
MIT License
1.6k stars 215 forks source link

[Lua]Add support for oapiOpenInputBoxEx #456

Closed TheGondos closed 5 months ago

TheGondos commented 5 months ago

This PR adds support for the oapiOpenInputBoxEx function in ScriptVessels/ScriptMFDs Differences with the C++ version : -callbacks only take 2 arguments (str and usrdata) since the first "void *id" is useless -cancel callback does not need to return a bool since it's ignored by the core anyway

TheGondos commented 5 months ago

What's the strategy for the Lua documentation? I don't like adding new APIs without at least minimal documentation...

jarmonik commented 5 months ago

There is no strategy for LUA documentation as far as I can tell. So, would you have some recommendations ? Would it be possible to exploit doxygen and modified versions of OrbiterAPI.h and VesselAPI.h for documentation ?

TheGondos commented 5 months ago

OK, I was not sure if the API doc was handled in the LaTeX work or not. I'll try to see what I can do with the ldoc stuff lying around then. I won't do this in this PR so it's ready to merge