search

orbitersim / orbiter

Open-source repository of Orbiter Space Flight Simulator
MIT License
1.61k stars 220 forks source link

Hover Engine Glass Cockpit Indicator is Backwards in Fullscreen 2560x1080 #464

Closed n7275 closed 4 months ago

n7275 commented 5 months ago

image

image

n7275 commented 5 months ago

This issue is also present as far back as the Orbiter 2016 d3d9 client. Not a new issue, I'm just noticing it now.

TheGondos commented 4 months ago

In defpanel.cpp there might be something :

    // Update hover engine status
    vofs += 4;
    if (g_focusobj->NumThrusters(THGROUP_HOVER)) {
        th = g_focusobj->GetThrusterGroupLevel (THGROUP_HOVER);
        if (th != enghovr) {
            enghovr = th;
            grp->Vtx[vofs+1].x = grp->Vtx[vofs+3].x = (float)((46.0+enghovr*94.0)*scale+gapw);
        }
    }

The '+gapw' is not done when drawing other statuses (fuel/main engine) and seems related to the gap width between MFD buttons. Not sure it has something to do with the hover engine status... Maybe you can try to remove it and see what happens? (I cannot reproduce the issue because my monitor won't do more than 1920x1080)

n7275 commented 4 months ago

I'll test it out.

On Sun, Jun 30, 2024, 06:38 TheGondos @.***> wrote:

In defpanel.cpp there might be something :

// Update hover engine status vofs += 4; if (g_focusobj->NumThrusters(THGROUP_HOVER)) { th = g_focusobj->GetThrusterGroupLevel (THGROUP_HOVER); if (th != enghovr) { enghovr = th; grp->Vtx[vofs+1].x = grp->Vtx[vofs+3].x = (float)((46.0+enghovr94.0)scale+gapw); } }

The '+gapw' is not done when drawing other statuses (fuel/main engine) and seems related to the gap width between MFD buttons. Not sure it has something to do with the hover engine status... Maybe you can try to remove it and see what happens? (I cannot reproduce the issue because my monitor won't do more than 1920x1080)

— Reply to this email directly, view it on GitHub https://github.com/orbitersim/orbiter/issues/464#issuecomment-2198513524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYP35FGNSWLWFV4LLEJALZJ7NYXAVCNFSM6AAAAABJDIITVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGUYTGNJSGQ . You are receiving this because you authored the thread.Message ID: @.***>

n7275 commented 4 months ago

removing the "gapw" and adding a "dx+" fixed the issue.

PR is up #468