search

orbitersim / orbiter

Open-source repository of Orbiter Space Flight Simulator
MIT License
1.61k stars 220 forks source link

fix: tab out/scroll mouse permanently disappearing bug #490

Closed ZigTag closed 2 months ago

ZigTag commented 2 months ago

I was talking to some of the community members in the NASSP discord, and they informed me that the disappearing mouse bug that would happen when tabbing out and zooming while scrolling over a switch while being in the right click (RotationMode), was not an isolated bug. So I decided to take it upon myself to fix it.

The problem is that the reference counter on the ShowCursor function would increment too high due to loosing focus, so it checks that it is below a certain threshold and tries to rectify it by calling the function again.

ThatRedMelon commented 2 months ago

This has been a highly annoying bug for many years, I would highly recommend including this PR in the Orbiter2024 release.

TheGondos commented 2 months ago

Did several trials of alt-tabbing while rotating the view with the mouse. The cursor always reappeared when right-clicking to cancel rotation mode after getting the focus back. Without the patch, the cursor bug appeared quickly doing the same scenario.

ZigTag commented 2 months ago

I'mma just move everything to #491