search

orbitersim / orbiter

Open-source repository of Orbiter Space Flight Simulator
MIT License
1.62k stars 220 forks source link

Crash protection after deleting the last vessel. #495

Closed MishaPhysics closed 2 months ago

MishaPhysics commented 2 months ago

It's known that Orbiter crashes to desktop when trying to delete the last vessel from simulation using Scenario Editor. It would be nice to protect the last vessel from deleting.

TheGondos commented 2 months ago

That should be straightforward, I can have a look at it. Edit : fixed in #497

n7275 commented 2 months ago

I'm okay merging this for the 2024 release. Let's just make sure that it doesn't effect deallocation, or deleation of vessels by Orbiter on simulation close.

On Sat, Sep 21, 2024, 17:19 TheGondos @.***> wrote:

That should be straightforward, I can have a look at it

— Reply to this email directly, view it on GitHub https://github.com/orbitersim/orbiter/issues/495#issuecomment-2365324134, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYP36JR7JJBAXI4HACZYDZXXPFVAVCNFSM6AAAAABOSDVWXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGMZDIMJTGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

TheGondos commented 2 months ago

The change only impacts the scenario editor when clicking the delete button, nothing was changed in the Orbiter core.