Simplified Tables: Example on Users List

orbiting / republik-admin-frontend

[DEPRECATED] moved to https://github.com/republik/plattform A front end to manage users and payments of Republik.

6 stars 3 forks source link

Simplified Tables: Example on Users List #24

Closed lukasbuenger closed 5 years ago

lukasbuenger commented 5 years ago

Changelog:

refactor components/Users/List/TableBody.js and components/Users/List/TableHead.js into one component Table.js using HTML5 tables in combination with position: sticky.

Reasoning:

We could get rid of react-sticky-el.
We could get rid of the micro-abstractions in components/Layout (in the long run).
Easier handling of tables because not scattered between files.

lukasbuenger commented 5 years ago

@tpreusse All the tables are refactored. Might want to have a look.

Also, there is components/base/tables which aims at collecting everything that's used in all tables in a domain specific way: Instead of import tableStyles from 'styles/tables you would import { tableStyles } from 'base/tables

I don't know if base is a good namespace but it feels better than utils.

lukasbuenger commented 5 years ago

Will do! Thanks for checking