Drop Browser Notification Code

orbiting / republik-frontend

[DEPRECATED] moved to https://github.com/republik/plattform The front end of the online magazine Republik.

https://republik.ch

BSD 3-Clause "New" or "Revised" License

70 stars 13 forks source link

Drop Browser Notification Code #703

Closed tpreusse closed 2 years ago

tpreusse commented 2 years ago

With the new action bar last year browser notifications stop being dispatched.

I recently discovered that the old discussion notification component, which also took care of the dispatching them, is still in the code base but unused. So I decided to remove it and also remove all browser notification related settings.

While at it I refactored components/Notifications/NotificationOptions.js (used on notification settings page) to be a function component and to properly display server errors.

tpreusse commented 2 years ago

@ovbm while testing a noticed that the callout had race condition (because of unnecessary local state) and didn't handle server errors: https://github.com/orbiting/republik-frontend/pull/703/commits/4c6c12864dffd3a680004f380decbc24285a165e

Fix that and also clean up the title styles and spacing: https://github.com/orbiting/republik-frontend/pull/703/commits/4e4292b12c1fa8c8c46a19e1b521f827d35f0ff7

ovbm commented 2 years ago

can you post a before after screenshot of the margin changes?

tpreusse commented 2 years ago

@ovbm after on the right hand side: