[Docs] Update "Relationship filtering" section in querying docs

[bradjones1]

• The header I think should be an H3, otherwise it doesn't show up in the navigation and gets lost.
• In my testing, it looks like the correct key is records in the relationship filter object... it's inconsistent between the two examples.

[dgeb]

Thanks for the PR @bradjones1 :)

In my testing, it looks like the correct key is records in the relationship filter object... it's inconsistent between the two examples.

For hasOne relationships the filter checks record not records. For hasMany relationships, records is checked.

If you're seeing different behavior, can you specify which version of orbit and which orbit source (memory / jsonapi / etc) you're using?

[bradjones1]

Thanks for the gut-check on that. I actually moved to getting the records in question via an include from a related entity, so I don't have that code anymore. I think I might have just had myself turned in a knot.

I think this still should be under an H3 though ;-)

[dgeb]

Ah thanks for the clarification on the filter.

The header I think should be an H3, otherwise it doesn't show up in the navigation and gets lost.

I can see what you mean that this rather important heading gets lost in the side nav. The issue with just changing this one H4 -> H3 is that there is another section just above, Attribute filtering, that should be at the same level as Relationship filtering. I think we can make this work by doing the following:

• Drop the header ### Comparison operators for filtering entirely, since it adds little, but keep the section's brief contents.
• Change #### Attribute filtering -> ### Attribute filtering

Would you mind making these two additions to your PR?

[bradjones1]

Done, thanks for the review.

[dgeb]

Looks great, thanks @bradjones1!