orbitjs / orbit

Composable data framework for ambitious web applications.
https://orbitjs.com
MIT License
2.33k stars 134 forks source link

`JSONAPIURLBuilder::buildPageParam()` (and likely others) have undefined properties serialized as `undefined` in query param #958

Open bradjones1 opened 2 years ago

bradjones1 commented 2 years ago

I wanted to use .page({limit: 10}) in a findRecords transform, however if you don't also provide the offset key, its value gets serialized into undefined (the literal string) in the query param, making my backend choke. I couldn't quite figure out where the serialization happens, but I figure this method (and likely others) need to handle absent optional parameters by excluding them?