I added "sideEffects": false to the package.json of every non-private package — in other words, to all packages, except
the root package,
orbit-website,
@orbit/build,
and @orbit/integration-tests.
I think it's safe to say that the public packages are side-effect-free, or at least the benefit of flagging them as such outweigh the small probability that there may exist scenarios where one or several of the packages cannot be considered 100% side-effect-free. For the private packages, I don't think it's worthwhile spending time thinking about whether they are side-effect-free or not, as they never need to be tree-shaken by bundlers.
dgeb
commented
1 year ago
Addresses #969.
I added
"sideEffects": falseto thepackage.jsonof every non-private package — in other words, to all packages, exceptorbit-website,@orbit/build,@orbit/integration-tests.I think it's safe to say that the public packages are side-effect-free, or at least the benefit of flagging them as such outweigh the small probability that there may exist scenarios where one or several of the packages cannot be considered 100% side-effect-free. For the private packages, I don't think it's worthwhile spending time thinking about whether they are side-effect-free or not, as they never need to be tree-shaken by bundlers.