Iterate more correctly over localStorage keys

orbitjs / orbit

Composable data framework for ambitious web applications.

https://orbitjs.com

MIT License

2.33k stars 134 forks source link

Iterate more correctly over localStorage keys #981

Closed ApexDevelopment closed 6 months ago

ApexDevelopment commented 1 year ago

Check for "inverseRels" keys when iterating over localStorage. This means we won't accidentally end up with inverse relationship data as part of the records we return from a call to findRecords() without a type argument. This was causing normalization errors when trying to restore all records from a localStorage backup.

Also switches from for...in to for...of as this allows polyfills to control iteration via the Symbol.iterator property on the localStorage object.

ApexDevelopment commented 6 months ago

Is this project dead? If so can it be marked as archived so people stop trying to PR?