search

orbitjs / orbit

Composable data framework for ambitious web applications.
https://orbitjs.com
MIT License
2.33k stars 134 forks source link

Add "validatorFor" to RecordTransformBuffer #984

Open enspandi opened 1 year ago

enspandi commented 1 year ago

As otherwise it will ignore custom validators.

I also tried passing in a custom transformBuffer to the indexeddb source settings as mentioned in https://github.com/orbitjs/orbit/pull/868 - but it is not passed forward to the indexeddb cache settings....

enspandi commented 1 year ago

@dgeb I should note that custom validator works with Indexed db source if

settings.defaultTransformOptions = { useBuffer: true };

is not set.

It seems to run the validation process of the indexeddb cache class which uses the correct validatorFor function. But in case of useBuffer: true it will create a new transform buffer class that does not have it.