search

orbland / contracts

🔮 Orb and related contracts. Auction + Harberger taxed ownership + invocations.
https://orb.land
MIT License
22 stars 5 forks source link

Remove 1 year requirement from bidding #19

Closed odyslam closed 1 year ago

odyslam commented 1 year ago

After discussions with @lekevicius, we aligned on removing the requirement from the protocol side of transferring more funds than the bid amount and adding UI affordances to help the user calculate how much funds they have to transfer to support a bid for X amount of time.

lekevicius commented 1 year ago

Let's keep the requirement the same as in purchase() -- you have to have MORE than bid, but we don't specify how much more. You can have 1 wei more. So not >=, but >.

odyslam commented 1 year ago

This is because if it's equal, it means that the very next second, it will be foreclosed?

It feels like code-smell. We should either have a sensible minimum (e.g a day) that stems from product requirements or stick to the protocol soundness(what I prefer) and allow the user to have equal (even if it doesn't make sense from a ux pov).

lekevicius commented 1 year ago

This has been implemented, without requiring anything more than necessary. Closing the issue.