The modifiers onlyHolderSolvent and onlyHolder are always used together in the codebase. That indicates that they should not be different modifiers.
Suggestion
Simplify the codebase, remove the modifiers, and introduce onlySolventHolder modifier that checks for both a) solvency and b) that msg.sender is the holder.
Description
The modifiers
onlyHolderSolventandonlyHolderare always used together in the codebase. That indicates that they should not be different modifiers.Suggestion
Simplify the codebase, remove the modifiers, and introduce
onlySolventHoldermodifier that checks for both a) solvency and b) that msg.sender is the holder.