Closed odyslam closed 1 year ago
Can we separate this issue? I fully agree with removing modifiers from getters and UX guardrails, but less convinced on removing onlyHolderHeld. Maybe that can be moved to a separate issue, and then we can confirm this smaller one?
Description
The codebase makes extensive use of modifiers. There is room for consolidation and simplification to improve the readability of the codebase.
Suggestion
minimumBid()
,lastSettlementTime
,holderSolvent
,price()
,foreclosureTime
,cooldownRemaining
hasFunds