[INF] foreclosureTime does not need to be internal

orbland / contracts

🔮 Orb and related contracts. Auction + Harberger taxed ownership + invocations.

https://orb.land

MIT License

22 stars 5 forks source link

[INF] foreclosureTime does not need to be internal #27

Closed odyslam closed 1 year ago

odyslam commented 1 year ago

Description

foreclosureTime does not need to have an access modifier for the public getter and be internal. It's a UX guardrail that increases the codebase with no real protocol value.

Moreover, no need to check that _price != 0. If it's set to zero, it will simply revert.

Suggestion

Make function public, remove modifier
Remove check for zero that returns INFINITY

lekevicius commented 1 year ago

I really like special value INFINITY which can be used as a signal to the UI, in two conditions where that is the value we want to communicate. Communicating via reverts is not fun. Currently don't want to change that aspect.

Removing getter modifier is ok.

odyslam commented 1 year ago

Function was made public, INFINITY is left and ack by team