orbland / contracts

🔮 Orb and related contracts. Auction + Harberger taxed ownership + invocations.
https://orb.land
MIT License
22 stars 5 forks source link

Remove `onlyHolderHeld` if `onlyHolder` AND `external` are in the same function: `setPrice`, `exit`, `flagResponse`. If it's external, it can't be called by the contract itself. #30

Closed odyslam closed 1 year ago

odyslam commented 1 year ago

Description

26

Suggestion

Removee onlyHolderHeld if onlyHolder and external are present in the function.

Affected functions: setPrice, exit, flagResponse.

lekevicius commented 1 year ago

Great suggestion.