orblazer / plasma-applet-resources-monitor

Plasmoid for monitoring CPU, memory, network traffic, GPUs and disks IO.
https://www.pling.com/p/2143899/
GNU General Public License v3.0
57 stars 6 forks source link

[BUG] CPU frequency and temperature missing #47

Closed madeddy closed 1 year ago

madeddy commented 1 year ago

Describe the bug CPU frequency and temperature values don't display anymore. Percentage is still working.

To Reproduce

  1. Install or update to v2.9.1
  2. Choose CPU frequency or temperature output display

Expected behavior To show the missing data.

Screenshots Screenshot_20230510_094615 Screenshot_20230510_094123

Versions (please complete the following information):

Thats a Kubuntu 22.04.2 i'm running.

Additional context

orblazer commented 1 year ago

Hello, This look same issue to https://github.com/orblazer/plasma-applet-resources-monitor/issues/37#issuecomment-1536791937.

Can you try to create new page in org.kde.plasma-systemmonitor ("System Monitor") app and select this sensors : CPU > All > Averaage CPU Frequency and CPU > All Average CPU Temperature ? IF there are right value could you provide me the page created ? IF there not present, that look an issue come from libksysguard and that can't be fixed by my but i can make an temporary fix for that.

Thanks.

madeddy commented 1 year ago

Thanks for the quick reply.

This look same issue to #37 (comment).

Could be very well.

... select this sensors : CPU > All > Averaage CPU Frequency and CPU > All Average CPU Temperature ?

Not possible because there are no average values available for temp and freq: Screenshot_20230510_124041

Only values per core can be chosen and they're working.:

Screenshot_20230510_124721

Is it possible for my CPU (Ryzen 7 5700G) is no average sensor for this available? I cannot remember ever having the average values in the settings and i didn't get any KDE updates or the likes of "libksysguard" in the last month(I could very well overlooked it, true). Also, a few days back it did still work... I think this came with the v2.9.0...

If for my CPU no averages exist, as a fallback, the widget could produce them with a little math func from the "per core" sensor values, or not?

Greets

eyforia commented 1 year ago

Same issue here, on Intel 12th gen i5. Started around the same time (may 10th, 2023), right after the update

orblazer commented 1 year ago

OH ok, that explain everything, Thanks ! And in fact that issue appear in 2.8.0 with that commits :

How i can implement the fix ?

So i go to revert that changes and simply make my own average. I think to 2 ways for manage that :

  1. create an selector for select between "average value" and each cores
  2. create checkoxs for each cores and let user select what cores want use in the "average" (BUT personally i think is useless to select only some of cores for that.

And for temperature i go to simply use the first core because all values look to be always same. And in same time i think i go to report the issue or dig if that missing values is normal in libksysguard.

NOTE: I'm open to any proposition or what way you prefer to fix that issue. NOTE2: If you want temporarily fix that issue (until next update), you can simply change 2 last all by cpu0 at this line https://github.com/orblazer/plasma-applet-resources-monitor/blob/master/package/contents/ui/components/graph/CpuGraph.qml#L42

eyforia commented 1 year ago

I agree with your assessment - No 1 looks reasonable and I -don't see how No 2 might be needed/useful :+1:

orblazer commented 1 year ago

@eyforia could you provide my KDE Plasma Version and KDE Frameworks Version ? I go to create an bug report on KDE for that.

eyforia commented 1 year ago

KDE Plasma 5.24.7 KDE Frameworks 5.92.0

I hope this helps

orblazer commented 1 year ago

Ok, so yes that is broken due to average value appear in 5.25. I go to make my temporary fix like i have said above, but in 3.0 i will drop support of old versions to use news components.

Noe: the v3 is not planned yet because i wait KDE to release they major update.

madeddy commented 1 year ago

Thanks. I agree like @eyforia also to your proposal. Opt1 it is and opt2 makes not much sense.

Not related to this issue, but while we're at it: See screen.

Screenshot_20230512_131506 If you disable on of this options(temp, freq)the space the element normally takes isn't given free, so the component(cpu, disk ...) stays in size the same. Intended behavior or small bug?

orblazer commented 1 year ago

@madeddy Thats is because the graph have they own size and the text is just an "overlay" of that graph.

madeddy commented 1 year ago

Ah, i understand. OK. Thanks for clearing this up. 👍🏻