[BUG] Settings has no labels (appearance -> charts -> width/height)

orblazer / plasma-applet-resources-monitor

Plasmoid for monitoring CPU, memory, network traffic, GPUs and disks IO.

https://www.pling.com/p/2143899/

GNU General Public License v3.0

57 stars 6 forks source link

[BUG] Settings has no labels (appearance -> charts -> width/height) #60

Closed GM-Script-Writer-62850 closed 5 months ago

GM-Script-Writer-62850 commented 1 year ago

Current Behavior

no label on width/height

Expected Behavior

Know this setting does without hitting apply (or some general idea) you know if could adjust the vertical margins separate from the horizontal margins that would be nice

Steps To Reproduce

install widget -> go through settings

Screenshots

If i could copy/paste this i would have:

Logs

Not relevant to this bug

Versions

Operating System: Kubuntu 22.04
KDE Plasma Version: 5.24.7
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.3
Kernel Version: 5.19.0-46-generic (64-bit)
Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 3600 6-Core Processor
Memory: 15.6 GiB of RAM
Graphics Processor: AMD Radeon RX 580 Series

Additional context

No response

orblazer commented 7 months ago

Hello, Do you still have that bug ?

GM-Script-Writer-62850 commented 7 months ago

let me update it... somehow i am on 2.9.0 when i was on newer??? still having that issue with updates for this applet

looks like i am... no labels on the settings (now on the latest f475487)

Screenshot_20240209_112925 Screenshot_20240209_112907

GM-Script-Writer-62850 commented 7 months ago

upon looking at what that last patch added, i think something is broken more than just the updating process the new setting does not appear

are there any files outside of ~/.local/share/plasma/plasmoids/org.kde.resourcesMonitor-fork/

orblazer commented 7 months ago

I think your issue is due to Kirigami (the lib i use for GUI) itself, because in release 5.96.0 it have Fix checkable labels (src: https://kde.org/announcements/frameworks/5/5.96.0/). And i'm not sure if it's worth to revert https://github.com/orblazer/plasma-applet-resources-monitor/commit/50817101ae23c1a10c30cc3585f37712154a8ba0 now due to plasma 5.24 is no longer maintained and the release 2.x of my widget will pass in feature frozen and in "LTS" and only support plasma 5.27.

For the new unreleased feature use [Appearance] > displayment (stored in ~/.config/plasma-org.kde.plasma.desktop-appletsrc).

GM-Script-Writer-62850 commented 1 week ago

now that i upgraded to kubuntu 24.04 this is not a issue (widget version: 2.11.4)