search

orblazer / plasma-applet-resources-monitor

Plasmoid for monitoring CPU, memory, network traffic, GPUs and disks IO.
https://www.pling.com/p/2143899/
GNU General Public License v3.0
57 stars 6 forks source link

Updated Dutch translation #78

Closed Vistaus closed 5 months ago

Vistaus commented 5 months ago

🙂

Vistaus commented 5 months ago

Hello,

That's odd. I used the exact same file as in the last PR, so there should not be anything wrong. I have no idea what happened. I'll look at it again tomorrow. 🙂

orblazer commented 5 months ago

This is due to changes i have made between your first commit and now, like i have mentioned here https://github.com/orblazer/plasma-applet-resources-monitor/pull/76#issuecomment-2028910882.

Also if you want i can co commit with you and have the clean commit in #79 like i have done for german.

Vistaus commented 5 months ago

That would be nice, thanks. 🙂 How do we do that?

orblazer commented 5 months ago

Hello, Since the file look based on 2.x (or at the start of 3.0) i think the best is to merge the 3.0 branch here, make your changes and after i pick your commit and i co-author it with you in the other PR.

Vistaus commented 5 months ago

Hi, thanks for your answer! I'll look at it again. Life didn't exactly go as planned the past few days, I'll try to do it again the right way today or tomorrow. 🙂

Vistaus commented 5 months ago

Alright, everything should be good now. 🙂

orblazer commented 5 months ago

Hello, Thanks for the update, once the last change is fixed i will make co-commit to have clean commit (without modify header and without commented messages).

orblazer commented 5 months ago

i have commit it here : https://github.com/orblazer/plasma-applet-resources-monitor/pull/79/commits/33e9a97ce6fd5c639b326019cdb4a93f678cabef could you review the commit ?

Vistaus commented 5 months ago

Looks good to me! 👍 🙂