Better view reporting

[vistra]

• Pass view to onCommit to enable the viewAtLastCommit metric
• Change onElectionCB to onNewView, so the callback will be called in the begining of each view, regardless of whether it was due to an election trigger, new term, new view msg, view changes, etc.

[vistra]

There is no change in encapsulation - orbs-network has the lean-helix-service wrapper which uses this. The caller from orbs is aware of lean helix. Notice that the previous callback referred to elections which is also a lean helix concept.

On Mon, Dec 2, 2019, 18:14 Ron Bresler notifications@github.com wrote:

@ronnno commented on this pull request.

I'm not sure we can externalize the idea of a "view" in the Orbs-Consensus interface, for violation of encapsulation: LeanHelix defines the concept of view, elections and term but other consensus algorithms may defined different constructs.

I would rather see an abstraction of the metrics mechanism passed to LH so it can decide what events to log, and allow other consensus mechanisms to manage different consensus metrics. what do you think?

maybe we should take this question to Gad - can we expect any consensus mechanism to keep the same metrics?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/orbs-network/lean-helix-go/pull/89?email_source=notifications&email_token=AMH4NCP4Y3CN5OWGHCFT3YTQWUX6JA5CNFSM4JSCKLEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNSINII#pullrequestreview-325355169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMH4NCIOI2IDMBGSCIEVQNLQWUX6JANCNFSM4JSCKLEA .