orbs-network / orbs-network-go

Orbs node virtual chain core reference implementation in Go
MIT License
48 stars 12 forks source link

Remove reliance of gamma server on host.docker.internal #1195

Open electricmonk opened 5 years ago

electricmonk commented 5 years ago

Gamma today talks to Ganache via host.docker.internal, an undocumented feature of Docker. This doesn't work well on Linux, forcing us to add this host to /etc/hosts manually in our docker-compose files.

It would be better to solve this differently, allowing Gamma to take an environment variable and making the connections between Gamma and Ganache in a different manner.

netoneko commented 5 years ago

It is a documented feature: https://docs.docker.com/docker-for-mac/networking/

You can use -config-override option for gamma to make it talk to anything you want, including ganache in docker-compose without any /etc/hosts tricks.