search

orbs-network / orbs-network-go

Orbs node virtual chain core reference implementation in Go
MIT License
47 stars 12 forks source link

Memory leak tests are currently skipped #1346

Open IdoZilberberg opened 4 years ago

IdoZilberberg commented 4 years ago 
* paste test failure summary here (copy from CI) *
Condition failed!
            Test:           TestMemoryLeaks_DuringRuntime
            Messages:       Heap size increased too much during runtime.
                            Pre-run: 19907640 bytes, during-run: 23072440 bytes, added 3164800 bytes. 
                            This is more than 10% of initial memory and more than the allowed addition of 1048576 bytes. 
                            Compare /home/circleci/project/_out/memory_leaks/mem-runtime-before.prof and /home/circleci/project/_out/memory_leaks/mem-runtime-after.prof to see memory consumers

This test should take memory samples within TestGazillion instead.

electricmonk commented 4 years ago

we need to decide if we want to fix these tests, or whether we're counting on Marvin to pinpoint any memory issue we might have