search

orbs-network / orbs-network-go

Orbs node virtual chain core reference implementation in Go
MIT License
48 stars 12 forks source link

Please follow the spec and make this configurable #55

Closed talkol closed 6 years ago

talkol commented 6 years ago

https://github.com/orbs-network/orbs-network-go/blob/3cb919e064be64ebecf7c5c1e372c65f52abce60/services/blockstorage/service.go#L85

The number 5 is not hardcoded anywhere, it's just an example

jlevison commented 6 years ago

indeed, and its one of the comments on the code, it should not be configuration, it should come from the behavior of the contract/vchain (or something else, need to implement more)

talkol commented 6 years ago

You can add it to the configuration in /config

All the configuration there will eventually come from contract/vchain configs

Currently we're using the in-memory hard-coded config just to for tests, the real deal will have an implementation that conforms to the same interface and will take the data from elsewhere (like a smart contract in the future)