search

orbwoi / UniversalRemote

A mod for minecraft forge 1.12
MIT License
4 stars 6 forks source link

0.9.5 breaks Skins - every Player has the female Alex default skin. #14

Closed D3nnis3n closed 6 years ago

D3nnis3n commented 6 years ago

I just tried out your new version - now everyone hast the female Alex default skin. After removing your mod, it's fine.

orbwoi commented 6 years ago

What the.. ?! Let me look at that. haha.

orbwoi commented 6 years ago

Uhh.. are you sure? https://ibb.co/nFGjiw

D3nnis3n commented 6 years ago

Yes. I am :D Wait for screenshot.

orbwoi commented 6 years ago

Can you test with ONLY my mod to confirm?

D3nnis3n commented 6 years ago

Works in SSP, not in SMP.

D3nnis3n commented 6 years ago

Yeh, i can.

orbwoi commented 6 years ago

I may close these bugs for now until we get some more data. I cannot reproduce the error on my machine. You should open a new bug if you find better way to reproduce it especially without optfine installed. Also, let me know if those other players see similar issues.

D3nnis3n commented 6 years ago

I got new info. It's not server dependent.

I tried joining onto my server 30 times. Ten times i was alex. 20 Times i was my skin. Also, it can happen while in game - you jsut suddenly change your skin and the GUI fails.

D3nnis3n commented 6 years ago

Okay, one of my players sees me as president, while i see me as president, too. He joined five times. One time he was alex for his view, but i still do see him as his real skin. He has the gui bug as soon as he is alex. I also can join ten times to be randomly alex for me but to be seen as president for him.

See screenshot: My view: https://ibb.co/f0b6Dw His view: https://ibb.co/bv9RDw

Does only occur with your mod installed.

If you still think this bug does not exist, i'll just give up and cease using the mod. I tried my utmost best to show you what happend. I can't do anything more than that and this makes me angry.

There is a bug. I'm sure. That is as weird as the block placing bug when it was incompatible.

D3nnis3n commented 6 years ago

Try joining twenty times in a row. You must be getting an alex and the gui bug at least once. :O

orbwoi commented 6 years ago

So if I just rejoin without re-starting client or server over and over it might happen? That would make testing much easier.

It's very interesting that you see yourself as Alex/Steve but the other player doesn't.. hmm...

D3nnis3n commented 6 years ago

Yes. And it even can happen WHILE playing ingame. Your Skin just changes to Alex and the GUI stops working after that. Sorry, i sniffed packages for networking, i did read the console, i did everything i could. But i'm done here. I know there must be an issue. I do fully understand it's fucking hard to fix issues you can't easily reproduce, but there is a point where even i stop testing and just remove the mod as it's not worth it. In the last four weeks i tested so many mods so much that i opened hundreds of issues with hundreds of valid ones. Complete *Metals Suite, Currency, Car Mod, Animania. I give my utmost best to give all info i can. But i can't get more info out of this.

I just can show you proof it does happen, but i don't know why. :(

orbwoi commented 6 years ago

No, I understand. I have to think carefully how this might happen. I may need to just give you a test fix if I can't get it happen for myself.

...

The most likely times for this to happen are either on server join or when you teleport to/from a custom dimension. When it 'just happens' did you recently change dimensions?

D3nnis3n commented 6 years ago

Yeh, it's just so disappointing for me. I had one of those very bad issues and after 3 days i found a way to reproduce, finally. But i can't seem to do this here.

Yes, it does happen on join. You join and might see Alex for a short time, then get your real skin. You might immediatly see your real skin. Or you might end up as alex.

When it does happen ingame, i did not change Dimensions, no. In fact, i had this twice after i tabbed out for discord and when i came back in, i was alex. So i thought tabbing out may cause it - but that was not reproducable also. So i did NOT see the skin change. In no case. In both times, i was tabbed out of the game.

orbwoi commented 6 years ago

Hmmmm...

When you say 'I got new info. It's not server dependent.' do you mean you see it in SSP? OR that you don't need to restart the server? You have never seen this in SSP right?

D3nnis3n commented 6 years ago

Yes, it's not server dependent. Not restarting the server was the cause, but rejoining the server as i found out.

And yes, i did never see this occuring in SSP. Only on my PTR-Server.

And yes, it does not make a difference which mods are installed.

(I even tried removing them one by one instead of all of them - which makes no sense, but i do that anyways whenever something is wrong. That is hard with 157 mods)

orbwoi commented 6 years ago

I will try spamming re-join on a server to see if I can make it happen. If not, can I send you some jar files to see if it works?

D3nnis3n commented 6 years ago

Yes, you can. Modders do that all the time with me :D

D3nnis3n commented 6 years ago

I could even send you my pack if you want to.

orbwoi commented 6 years ago

I have a theory... sent you a file on discord to try out.

orbwoi commented 6 years ago

Fixed in 0.9.6! :D