orbwoi / UniversalRemote

A mod for minecraft forge 1.12
MIT License
4 stars 6 forks source link

Fuel type none causes NPE when attempting to bind remote to block #42

Open TehBrian opened 2 weeks ago

TehBrian commented 2 weeks ago

The following NPE occurs when trying to bind the remote to a block via shift + right-click when the fuel type in the config is set to none.

[23:18:52] [Server thread/FATAL] [minecraft/MinecraftServer]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
    at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_412]
    at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_412]
    at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?]
    at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?]
    at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:185) [chd.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
    at java.lang.Thread.run(Thread.java:750) [?:1.8.0_412]
Caused by: java.lang.NullPointerException
    at clayborn.universalremote.items.ItemUniversalRemote.func_180614_a(ItemUniversalRemote.java:359) ~[ItemUniversalRemote.class:?]
    at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:889) ~[ForgeHooks.class:14.23.5.2859]
    at net.minecraft.item.ItemStack.func_179546_a(ItemStack.java:186) ~[aip.class:?]
    at net.minecraft.server.management.PlayerInteractionManager.func_187251_a(PlayerInteractionManager.java:492) ~[or.class:?]
    at net.minecraft.network.NetHandlerPlayServer.func_184337_a(NetHandlerPlayServer.java:741) ~[pa.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.func_148833_a(SourceFile:55) ~[ma.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.func_148833_a(SourceFile:11) ~[ma.class:?]
    at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[hv$1.class:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_412]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_412]
    at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?]
    ... 5 more

This essentially makes the fuel type none config option useless.

If the mod maintainers would be willing to publish an update (for 1.12.2, specifically), I will PR a fix.