orc-lang / orc

Orc programming language implementation
https://orc.csres.utexas.edu/
BSD 3-Clause "New" or "Revised" License
40 stars 3 forks source link

URL-based includes in "Try Orc" fail #74

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Procedure to Repeat:
1. In TryOrc, run a program containing an include statement of the form include 
"http://host/file.inc".

Expected / Actual Results:
:3:1: java.io.FileNotFoundException: Include file 'http://xxxx.inc' not found; 
check the include path.

Version and Platform:
Orchard 2.0.0

Original issue reported on code.google.com by jthywissen on 22 Apr 2011 at 9:04

GoogleCodeExporter commented 9 years ago
Works in local Orc -- something's broken about URL includes in Orchard

Original comment by jthywissen on 22 Apr 2011 at 9:42

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by jthywissen on 22 Apr 2011 at 11:14

GoogleCodeExporter commented 9 years ago
Root cause: We set the Orc include path to an empty list in Orchard, so tryorc 
programs can't read local files.  This has the effect of disallowing all 
includes that aren't of files bundled with Orchard.  We should allow 
network-based includes.

Fix StandardOrcCompiler.openInclude, in OrcCompiler.scala, accordingly.

Original comment by jthywissen on 25 Apr 2011 at 3:44

GoogleCodeExporter commented 9 years ago
Security implications of this require OrcScala and Orchard code changes, as 
well as orc.csres config changes.  Will be part of 2.0.1 release.

Original comment by jthywissen on 25 Apr 2011 at 7:27

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2827.

Original comment by jthywissen on 27 Apr 2011 at 9:30