search

orca-app / orca

A Wasm environment for cross-platform, sandboxed graphical applications.
https://orca-app.dev
Other
156 stars 13 forks source link

Fix off by one bug in strncmp #50

Closed bitwitch closed 7 months ago

bitwitch commented 7 months ago

When calling strncmp with an n value that is less than the length of the strings being compared, then the index variable i was being incremented one too many times and comparing one extra character. This patch fixes that.

martinfouilleul commented 7 months ago

Thanks! Saw your comment on the discord before your PR, so I fixed it in 5cc84169 instead of merging. Added an explicit check for n==0, too.