orca-app / orca

A Wasm environment for cross-platform, sandboxed graphical applications.
https://orca-app.dev
Other
156 stars 13 forks source link

Triangle and Fluid samples crash on launch #71

Closed bvisness closed 1 month ago

bvisness commented 2 months ago

On my M1 Macbook Air, the Triangle and Fluid samples crash on launch with the following error:

Error: oc_wgpu_canvas_on_device_error() in src/graphics/wgpu_renderer.c:395: Binding size for [Buffer "path buffer"] is zero.
 - While validating entries[0] as a Buffer.
Expected entry layout: { binding: 0, visibility: ShaderStage::Compute, buffer: { type: BufferBindingType::ReadOnlyStorage, hasDynamicOffset: 0, minBindingSize: 0 } }
 - While validating [BindGroupDescriptor] against [BindGroupLayout]
 - While calling [Device].CreateBindGroup([BindGroupDescriptor]).
martinfouilleul commented 1 month ago

Fixed by ffc3c8a1. See #72 for more details.

Here we were not entering the encode batch loop, but the overflow on the buffer size meant we were binding buffers with a size of 0, which is caught by wgpu validation.

Closing this issue, as further actions will be tracked in #72