token-sdk improvements - Githubissues

orca-so / orca-sdks

Open-sourced typescript SDKs for Orca

MIT License

43 stars 10 forks source link

token-sdk improvements #31

Closed terranmoccasin closed 1 year ago

terranmoccasin commented 1 year ago

Changing TokenMint to use a string instead of Address - works better with JSON files
Exporting FileSystemProvider
Updating default settings in providers for concurrent requests
Fix bug in Readonly type aliases
Adding options to TokenFetcher for request timeouts. When running into RPC socket hangups, the fetcher was hanging for a long time before throwing an unexpected error.
Treat tokens with only partial metadata as cache misses in the TokenFetcher

terranmoccasin commented 1 year ago

Hey @yugure-orca - thanks for the review! I've also added tests. Ready for another look.

terranmoccasin commented 1 year ago

Just to confirm, am I correct in understanding that the UI does not use this package directly, but uses the generated tokenlists?

Ah no, you're correct in your concern about logging in the browser. The package is intended for eventual use on both server and in web. I've removed the regular console.log statements in the normal code path!