Closed ghost closed 3 years ago
@odcheung - Thanks for the review! Pushed new commits which makes these changes:
Hey @odcheung, haha no worries! I really appreciate all the feedback, and sdk is better for it 🙂
Agree that we should be thoughtful around one-way-door decisions. I think in this case we definitely wanted to get it right because getDepositQuote, getWithdrawQuote will be an integral part of the SDK. Tangentially though, I think it's ok to push an api, then deprecate and add new versions of it without having api breaking changes (e.g. pool.someCoolMethod, later introduce pool.someCoolMethodV2).
Updated the PR with the following changes:
@odcheung - thanks for the review! updated the commented, and merging now. I'll also bump the version and publish it
Context
Changes
getDepositQuote(maxTokenAIn, maxTokenBIn, slippage?)
getWithdrawQuote(poolTokenIn, slippage?)
Usage Example