orcasgit / python-nokia

Library for the Nokia Health API
Other
57 stars 23 forks source link

Migrate to OAuth2.0 #12

Closed magnific0 closed 6 years ago

magnific0 commented 6 years ago

As the title says. I tried to update documentation (README) where I could. I didn't touch the tests, so they still need to be updated.

I tested the entire OAuth 2.0 process including refreshing the tokens and it works like a charm. Users should be careful to actually use the new get_credentials() function and update their configuration accordingly. Because access_token, refresh_token, and token_expiry all can change run time.

magnific0 commented 6 years ago

I removed the typo you spotted and added the commit to the PR. I'm glad to contribute something back, this library has been very helpful in my projects!

wangsha commented 6 years ago

+1