search

orcasgit / python-nokia

Library for the Nokia Health API
Other
57 stars 23 forks source link

Oauth 2.0 Update access_token in params after token update. #15

Closed magnific0 closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-2.4%) to 97.605% when pulling d781718c66fb01c035fcf8732dc7cebd0ac37d39 on magnific0:oauth2 into 086da46dc35fc7db9a80cf46dffb7cac16bb1c3f on orcasgit:oauth2.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-2.4%) to 97.605% when pulling d781718c66fb01c035fcf8732dc7cebd0ac37d39 on magnific0:oauth2 into 086da46dc35fc7db9a80cf46dffb7cac16bb1c3f on orcasgit:oauth2.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-2.4%) to 97.605% when pulling d781718c66fb01c035fcf8732dc7cebd0ac37d39 on magnific0:oauth2 into 086da46dc35fc7db9a80cf46dffb7cac16bb1c3f on orcasgit:oauth2.

brad commented 6 years ago

@magnific0 Awesome, I'm betting we could get this working using a compliance fix with a refresh_token_response hook type. I will explore this option.

magnific0 commented 6 years ago

@brad I was very intrigued by the hooks you mentioned, but couldn't find one that manipulated the params in any meaningful way. However, that did led me on to a much more simple (and what I think is the most proper) solution. In the last commit, I create a custom oauth2 webapplication such that the default_token_placement is changed from auth_header to url_query. Which is exactly what we want.

brad commented 6 years ago

@magnific0 Ahh, that is great!!