orcasound / aifororcas-livesystem

Real-time AI-assisted killer whale notification system (model and moderator portal) :star:
http://orcahello.ai4orcas.net/
MIT License
37 stars 25 forks source link

For aged authentication, UI confirms moderation, but queue is unchanged #126

Closed scottveirs closed 2 months ago

scottveirs commented 1 year ago

As a moderator who has apparently been authenticated (but not recently logged out and back in), I get a green confirmation message upon moderating a candidate (at least as a false positive), BUT that candidate then remains in the queue with the Submit button no longer active and the entered tag and comments cleared from their fields in the UI (as if it was not moderated).

Screen Shot 2022-12-03 at 10 31 47 AM Screen Shot 2022-12-03 at 10 31 52 AM Screen Shot 2022-12-03 at 10 31 55 AM

If I reload the page, the moderated candidate remains in that state (i.e. appears to have not yet been moderated).

Screen Shot 2022-12-03 at 10 36 41 AM Screen Shot 2022-12-03 at 10 36 45 AM

However, if I log out and the back in, those candidates can be re-moderated and the UI and backend behave as expected.

My sense is that this bug arose during/after the September 2022 hackathon.

I have not tested to see if it occurs if the candidate is marked as a "yes" (true positive) or "unknown," rather than a "no"

scottveirs commented 1 year ago

Val and Dave mentioned experiencing this bug as well in this week's Orcasound standup. Dave had a good thought: the optimal solution would be a UI change to ensure the moderator knows they are no longer successfully authenticated. As it is, the UI suggests one is still logged in when the authentication is actually expired or otherwise nonfunctional.