search

orcasound / ambient-sound-analysis

This repository aims to hold code for UW MSDS capstone project analyzing ambient sounds in orcasound hydrophone data
MIT License
5 stars 4 forks source link

Add broadband as 0 Column in PDS dataframes. #9

Closed CaseCal closed 1 year ago

CaseCal commented 1 year ago

As per discussion, the broadband value should be appended as the 0 column to the generated PDS dataframes.

There is currently a 0 column representing the lowest band, do we need to rename the column values to the middle or top of each band?

mitchhaldeman commented 1 year ago

wav_to_array returns the broadband result as a separate dataframe right now. We could easily just change that function to return one df with the broadband result as column 0.

CaseCal commented 1 year ago

After discussion, broadband will not be included. It is available to produce both on-demand or easily calculable from a more granular parquet artifact, so its a minor gain to pre-calculate compared to the added complexity of parsing and documenting the generated files.

scottveirs commented 1 year ago

That makes sense to me. Good call.

@veirs may want to chime in with a differing opinion, but I say proceed!

On Sun, Feb 26, 2023 at 15:39 Caleb Case @.***> wrote:

After discussion, broadband will not be included. It is available to produce both on-demand or easily calculable from a more granular parquet artifact, so its a minor gain to pre-calculate compared to the added complexity of parsing and documenting the generated files.

— Reply to this email directly, view it on GitHub https://github.com/orcasound/ambient-sound-analysis/issues/9#issuecomment-1445501122, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLE3MY6UH237WDJ3JMUR4TWZPSRZANCNFSM6AAAAAAVBDHYAE . You are receiving this because you are subscribed to this thread.Message ID: @.***>