test(spectrograms): compare np arrays, not files

orcasound / orca-action-workflow

Github actions to automate Orcasound tasks.

MIT License

7 stars 6 forks source link

test(spectrograms): compare np arrays, not files #49

Closed Molkree closed 3 years ago

Molkree commented 3 years ago

fixes #48

Files have the same size as far as I can see so it probably fails because of the differences in os.stat (most likely modification time). Changing it to comparing image arrays fixes the issue for me locally and through CI on my fork. Still, any change to matplotlib plotting behavior will probably break this but we'll see.

valentina-s commented 3 years ago

Ok, maybe it will be a bit fragile. We could loosen the tolerance but I am not sure about the range. Fine for now.