search

orcasound / orcadata

Development of bioacoustic tools for analyzing Orcasound data -- either post-processing of archived raw FLAC files or real-time analysis of the lossy stream and/or FLAC files.
GNU Affero General Public License v3.0
53 stars 23 forks source link

Changes regarding in WAV_FLACprocessor_Val/ProcessAWSFilesForCalls #25

Closed Durgesh93 closed 2 years ago

Durgesh93 commented 4 years ago

There are three changes which are done-

  1. S3bucket name was hardcoded in the scanAWSAudioFilesForCalls.py
  2. Added code of checking the existence of an output directory. The program showed an error when the mentioned output directory is not present.
  3. Removed the Linux specific path separators(forward slash) and use os.path.join to take os specific path separator dynamically.
  4. Removed unnecessary last argument to processFileForCalls function
scottveirs commented 2 years ago

@veirs These seem like worthy improvements. Would you like to review and potentially merge?

veirs commented 2 years ago

I will take a look.

On Thu, Jan 27, 2022, 12:08 PM Scott Veirs @.***> wrote:

@veirs https://github.com/veirs These seem like worthy improvements. Would you like to review and potentially merge?

— Reply to this email directly, view it on GitHub https://github.com/orcasound/orcadata/pull/25#issuecomment-1023596020, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFXKXMB47ERPIEN3ZP72H3UYGQ2LANCNFSM4LF4B4LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>