orcasound / orcamap-react

ReactJS version of Orcamap (current version of orcamap project)

MIT License

23 stars 34 forks source link

Coding standards #10

Open ivanoats opened 4 years ago

ivanoats commented 4 years ago

eslint runs prettier
css standard?
functional components and hooks over class based components
types if possible
anything else? comments and questions?

GarrySan commented 4 years ago

sass instead of css?

ivanoats commented 4 years ago

I don't think Sass is really necessary if we are using a css-in-js system styled components or css modules. It just adds an extra layer of tooling, and extra syntax to learn, in my opinion.

GarrySan commented 4 years ago

Yup, if we are using material-ui components then most of the styling will be of the css-in-js form, leaving very little components that we will need to style.

ivanoats commented 3 years ago

19 takes care of most of this. The PR just needs conflicts resolved

riteshsp2000 commented 3 years ago

Hey I had resolved the conflicts. But just saw now that other PRs were merged. I'll resolve the conflicts now and then it should be good to review

ivanoats commented 3 years ago

One we add these to https://github.com/orcasound/orcamap-react/blob/main/CONTRIBUTING.md we can close this issue.